Native Sign Up Various QA Fixes #7607

DejayJD · 2024-02-15T19:59:11Z

Description

Addresses all of these:

How Has This Been Tested?

ios:stage & android:stage

DejayJD · 2024-02-15T19:59:42Z

packages/mobile/src/components/fields/PasswordField.tsx

@@ -22,7 +22,6 @@ export const PasswordField = (props: PasswordFieldProps) => {
    <PasswordInput
      {...field}
      error={hasError}
-      helperText={hasError ? error : undefined}


Matches pattern on web where we dont show any text since the completion checks handle that

DejayJD · 2024-02-15T20:00:41Z

packages/mobile/src/harmony-native/components/CoverPhoto/CoverPhoto.tsx

+    // Android upload format does not quite match the expected format, so we have to drill into 'file' to workaround for android
+    if ('file' in source && !('uri' in source)) {
+      return { source: source.file, usingProfilePicture }
+    } else {
+      return { source, usingProfilePicture }


Android seems to have a slightly different upload format. I don't love this solution, but it does the job. Open to ideas of better options

DejayJD · 2024-02-15T20:01:19Z

packages/web/src/common/store/pages/signon/sagas.ts

+        if (isNativeMobile) {
+          if (!isSignUpRedesignEnabled) {
+            yield* put(requestPushNotificationPermissions())
+          }


This was the thing causing crashes on android (the else triggers window.localstorage)

yes great find!

audius-infra · 2024-02-15T20:09:12Z

Preview this change https://demo.audius.co/jd/mobile-qa-2

DejayJD · 2024-02-15T20:11:52Z

packages/mobile/src/screens/sign-on-screen/components/layout.tsx

@@ -47,6 +47,8 @@ export const Page = (props: PageProps) => {
      style={[
        css({
          zIndex: 1,
+          minHeight:


From what I can tell, Android seems to shrink height: 100% with the keyboard, whereas iOS doesnt?

that sounds right, unfortunate

DejayJD · 2024-02-15T20:12:32Z

packages/mobile/src/screens/root-screen/RootScreen.tsx

@@ -107,14 +109,19 @@ export const RootScreen = () => {
      if (showHomeStack && startedSignUp && !welcomeModalShown) {
        openWelcomeDrawer()
        setWelcomeModalShown(true)
+        // On iOS this will auto-navigate when we un-render sign up but on Android we have to navigate intentionally
+        if (navigate) {


Kept getting left on a blank page on Android 💀

DejayJD · 2024-02-15T20:12:46Z

packages/mobile/src/harmony-native/components/input/TextInput/TextInput.tsx

-                        variant='label'
-                        size='l'
-                        color='subdued'
-                        style={css({ lineHeight: 0 })}


The lineHeight was making the text dissappear on Android

audius-infra · 2024-02-15T20:34:19Z

Preview this change https://demo.audius.co/jd/mobile-qa-2

dylanjeffers

incredible! just double checking previews are working as expected too?

dylanjeffers · 2024-02-15T21:30:40Z

packages/web/src/common/store/pages/signon/sagas.ts

+        if (isNativeMobile) {
+          if (!isSignUpRedesignEnabled) {
+            yield* put(requestPushNotificationPermissions())
+          }


yes great find!

dylanjeffers · 2024-02-15T23:06:08Z

packages/mobile/src/harmony-native/components/CoverPhoto/CoverPhoto.tsx

 export type CoverPhotoProps = {
-  profilePicture?: Image | ImageSourcePropType | null | undefined
-  coverPhoto?: Image | ImageSourcePropType | null | undefined
+  profilePicture?: CoverPhotoImage


a little weird calling it CoverPhotoImage, but i guess i get it :)

dylanjeffers · 2024-02-15T23:06:35Z

packages/mobile/src/harmony-native/components/CoverPhoto/CoverPhoto.tsx

-    // Having .url means its a useable image source
-    if (coverPhoto && !isEmpty(coverPhoto)) {
-      return { source: coverPhoto }
+    let source: Exclude<CoverPhotoImage, number> = {


thanks a ton for improving this

dylanjeffers · 2024-02-15T23:07:19Z

packages/mobile/src/screens/root-screen/RootScreen.tsx

@@ -107,14 +109,19 @@ export const RootScreen = () => {
      if (showHomeStack && startedSignUp && !welcomeModalShown) {
        openWelcomeDrawer()
        setWelcomeModalShown(true)
+        // On iOS this will auto-navigate when we un-render sign up but on Android we have to navigate intentionally
+        if (navigate) {


dylanjeffers · 2024-02-15T23:07:42Z

packages/mobile/src/screens/sign-on-screen/components/layout.tsx

@@ -47,6 +47,8 @@ export const Page = (props: PageProps) => {
      style={[
        css({
          zIndex: 1,
+          minHeight:


that sounds right, unfortunate

[533a178] Fix release tag reference (#7660) Dylan Jeffers [87f0b90] [PAY-2512] Add more audio file type icons (#7658) Saliou Diallo [93018df] Bump version to 0.6.42 audius-infra [5693187] Fix generate-client-release script version (#7657) Dylan Jeffers [58f6fd5] [C-3851] Remove all "harmony" components from stems (#7637) Dylan Jeffers [206d386] Allow CI workflows to be manually triggered (#7656) Raymond Jacobson [eaacf44] [PROTO-1667] Add DDEX sessions and admin+artist auth (#7645) Theo Ilie [04bb965] PROTO-1574: sepolia config and register all nodes (#7648) alecsavvy [49ff569] [ONC-17] Remove hotkeys on unmount of playbar to prevent double-triggers (#7654) Randy Schott [f6b21ac] make dominant_genre_count nullable (#7653) Steve Perkins [e8a45c5] [PAY-2508] Fix download lossless mp3 failure (#7646) Saliou Diallo [fce5455] Fix native track-list play/pause icons (#7649) Dylan Jeffers [0db255e] Disable related artists job (#7652) Isaac Solo [73cab49] Bump version to 0.6.41 audius-infra [a522345] Bump version to 0.6.40 audius-infra [aa5fa95] Update dapp-store build artifacts audius-infra [99e5580] fix self album share button (#7647) alecsavvy [d7d42a2] Fix wallet connect icons [C-3871] (#7635) nicoback2 [ef0b2cd] Fix single download (#7643) Raymond Jacobson [8c7d4cb] [ONC-27] Update collection cache reducer to add track uids to tracks in playlist_contents if not present (#7642) Kyle Shanks [8f47040] [C-3852] Fix android bottom bar button colors (#7641) Dylan Jeffers [edda3f5] Update mobile app versions (#7639) Raymond Jacobson [83a9654] Fix mobile typecheck (#7640) Sebastian Klingler [25d45fa] Use more transcode workers on larger machines (#7363) Steve Perkins [d4dab56] [PAY-2509] Bring lossless downloads mobile web up to spec (#7638) Reed [40dd9bb] Cascade delete on dashboard wallet users fkey (#7636) Isaac Solo [b9e2778] [C-3733] Update tiktok user api usage to v2 (#7610) Sebastian Klingler [bf4cd5f] [C-3842] Add feature flag for native TikTok auth (#7634) Sebastian Klingler [efdb27e] [ONC-28] Fix track tile icon size (#7631) Kyle Shanks [dff9ae4] Fix android downloads (#7633) Raymond Jacobson [19ca463] Drop dashboard wallet users blockhash fkey (#7629) Isaac Solo [b5812fa] Mirror orig upload in parallel (#7630) Steve Perkins [71368df] Fix mobile @audius/common auto imports (#7632) Sebastian Klingler [fe4eda3] Fix and clean up more lossless downloads issues (#7626) Saliou Diallo [9d38155] Fix mobile play icons (#7628) Dylan Jeffers [469bf40] Persist active task log (#7627) Isaac Solo [dc3aa8d] [PROTO-1665] DDEX: Add failure states, fix write scope, and clean up (#7619) Theo Ilie [dde01a7] Bump version to 0.6.39 audius-infra [f90880e] Bump mobile versions (#7625) Raymond Jacobson [f468dd1] ⚠️ [PAY-2493] Replace RNFetchBlob with ReactNativeBlobUtil (#7624) Raymond Jacobson [f244cd7] Make user bank indexer run ever 1s instead of 5 (#7623) Raymond Jacobson [e52515c] Upgrade ruby from 2.7 to 3.1.4 (#7622) Dylan Jeffers [3ae7cf5] Fix audius-cmd health check (#7621) Raymond Jacobson [3a9d4e2] [PAY-2503] Fix mobile crypto transfer purchase flow (#7620) Raymond Jacobson [f8232bb] Native Sign Up Various QA Fixes (#7607) JD Francis [336bab2] Set up protodash for Harmony use [C-3843] (#7614) nicoback2 [4e707b0] Revert [C-3561] Improve playback delay when playing track on mobile (#7616) Dylan Jeffers [8004f92] Fix modal styles and remove unused hooks (#7615) Dylan Jeffers [25a83fd] [PAY-2493] Upgrade RNFetchBlob to 0.13.0-beta.1 (#7617) Raymond Jacobson [fa33251] Add priority fee ixs to purchase txs (#7613) Reed [b6a58ab] [C-3833] Migrate modal to harmony (#7596) Dylan Jeffers [349e87c] Indexers fetch confirmed sol txs instead of finalized (#7612) Reed [862c9e6] [C-3821] Fix native double save (#7609) Dylan Jeffers [75925a9] Log active tasks and mem usage (#7611) Isaac Solo [b47ef80] Push protocol dashboard better (#7608) Raymond Jacobson [e3ecd49] [PAY-2492][PAY-2500] Add waitlist for premium downloads (#7603) Saliou Diallo [069ab6f] [PAY-2498] Fix multiple download warning in web (#7604) Raymond Jacobson [e26dd70] [ONC-9] Fix profile image display in old sign up flow (#7606) Kyle Shanks [f5b038d] Run dashboard job on client release (#7605) Raymond Jacobson [2efe8af] [C-3709 C-3814] Fix native text aligment issues (#7598) Dylan Jeffers [c8178da] [C-3812] Upgrade xcode from 14x to 15x, migrate to m1 (#7579) Dylan Jeffers [9c42c99] Fix armada project id (#7597) Raymond Jacobson [4677d86] relay log cleanup (#7601) alecsavvy [e109394] Dedupe tracks in album and fix broken import (#7599) Theo Ilie [de6750b] Bump version to 0.6.38 audius-infra [0cd31cf] [PROTO-1664] Replicate transcode result in parallel (#7593) Steve Perkins [23edd81] ⚠️ [ONC-19] Error on failed gas estimation (#7569) Raymond Jacobson [58fd090] [C-3811] Migrate popup to harmony (#7576) Dylan Jeffers [a22dc7a] rework relay selection (#7539) alecsavvy [7af96f0] PROTO-1646: fix app verify in relay (#7595) alecsavvy [c9c9244] Bypass errors on health check for autoheal (#7582) Isaac Solo [d7b9259] [PROTO-1661] Make ddex download from S3 and publish via Audius SDK (#7552) Michelle Brier [c213244] [Web] Fix red icon kebab horizontal icon [C-3829] (#7594) nicoback2 [acd8e5e] Fix follow-gated download row on web (#7592) Reed [97f9e12] [PAY-2467] Fix purchased flickering on own downloadable tracks (#7591) Reed [199a1a5] [PAY-2485][PAY-2483] Adds download Retry behavior for mobile (#7583) Randy Schott [8d509fc] [DVRL-5.1] - multisig node registration walkthrough (#7530) Sam Gutentag [01b9389] [C-3732] Update tiktok oauth calls in identity-service to v2 (#7585) Sebastian Klingler [570d049] [PAY-2458][PAY-2463][PAY-2474] Add lossless downloads edit flow and other fixes (#7590) Saliou Diallo [3bcf175] Bump version to 0.6.37 audius-infra [1fe3be6] Relax timeout for re-doing transcode (#7581) Steve Perkins [4ae791d] Fix ddex indexer excluding nested resources (#7572) Theo Ilie [494c66f] Patch decimal return type serialization (#7589) Raymond Jacobson [154e20c] Fix edit/delete track sagas (#7588) Dylan Jeffers [193f59e] Add time limit for payment router (#7587) Isaac Solo [d1d318b] [ONC-20] Fix sign on page saga for fetching suggested artists (#7586) Kyle Shanks [ca7ddf1] Fix spacing in Token docs (#7584) Sebastian Klingler [ad3a35e] Fix action-button alignment (#7578) Dylan Jeffers [f59e66a] [DVRL-15] - Connect Audius Account To Protocol Dashboard With MetaMask Guide (#7549) Sam Gutentag [cb4a82b] Rewrite USDCCard in harmony-native to fix android text (#7577) Reed [bf1887d] [PAY-2465] Fix contextual menu stems (#7570) Raymond Jacobson [36f8f09] [PAY-2478] Add overshoot clamping to drawer close (#7573) Raymond Jacobson [ce72ac5] [PAY-2468] Dedup filenames during download (#7563) Reed [ba2263b] [C-3769] Fix where condition for aggregate_user query. (#7575) Steve Perkins [f4a240e] Convert saved lineup sagas to ts (#7453) Kyle Shanks [813d7ce] Remove extra horizontal padding from SegmentedControl tabs (#7574) Randy Schott [030ce6a] [PAY-2472] Make USDCManualTransfer modal buy button actually buy (#7571) Raymond Jacobson [8ebc8cb] Bump version to 0.6.36 audius-infra [7029d77] Don't render InputAccessoryView on non-iOS platforms (#7568) Marcus Pasell [420e56e] [C-3666] Add autocomplete fields to new sign up/sign in fields (#7567) JD Francis [5598860] [C-3659] Float continue button above keyboard on native OTP (#7566) JD Francis [589ed01] [C-3561] Improve playback delay when playing track on mobile (#7267) Dylan Jeffers [8b2e00e] Fix native handle field floating on the wrong side (#7565) JD Francis [2575478] Upgrade native for full release (#7521) Dylan Jeffers [2be1ade] [C-3804 C-3794] Fix native icon colors and size (#7560) Dylan Jeffers [ff80da2] Uses selected DN node for trpc endpoint (#7562) Steve Perkins [57033a5] [PAY-2486] Change Email: Copy changes and current email screen on mobile (#7564) Marcus Pasell [fe284c2] [PAY-2414] Remove manual mime type specification for Android downloads (#7561) Randy Schott [00b4df5] Improve Connect MetaMask UX, esp. when both MetaMask and Phantom are installed [C-3750] (#7537) nicoback2 [fbc00f5] [PAY-2469] Always show file size for downloadable files (#7559) Reed [ce1ff59] [PAY-2482] Purchase details modal downloadable content UI (#7548) Reed [887e0c2] [Web][Harmony] Forward ref in Harmony IconButtob; Fix red kebab icon and too big tip tile close icon (#7553) nicoback2 [59b8df9] Migrate some buttons to Harmony [C-3751] (#7488) nicoback2 [4eec211] [PAY-2484] Ensure temporary download files are always deleted (#7554) Randy Schott [f560b22] Fix structured data (#7556) Sebastian Klingler [28c70fa] Patch trpc batching (#7555) Steve Perkins [85181d0] Fix rive-react-native for ios and android (#7551) Dylan Jeffers [88d4037] Bump version to 0.6.35 audius-infra

DejayJD added 7 commits February 14, 2024 13:02

Remove helper text from password fields

44f611a

adjust Page layout to avoid keyboard movement issues

b21c946

fix cover photo issue on android

33d2283

Fix coverphoto

94a08b9

Fix android crashes

775a636

Add navigate on RootScreen to fix Android

2a169ef

add follow artists call to artist scree submission

f241cdd

pull-request-size bot added the size/L label Feb 15, 2024

DejayJD commented Feb 15, 2024

View reviewed changes

DejayJD requested review from dylanjeffers and a team February 15, 2024 20:12

DejayJD added 2 commits February 15, 2024 14:16

TS fixes

3580ab3

fix artist name alignment

912168e

dylanjeffers approved these changes Feb 15, 2024

View reviewed changes

DejayJD merged commit f8232bb into main Feb 16, 2024
17 of 18 checks passed

DejayJD deleted the jd/mobile-qa-2 branch February 16, 2024 01:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native Sign Up Various QA Fixes #7607

Native Sign Up Various QA Fixes #7607

DejayJD commented Feb 15, 2024 •

edited

Loading

DejayJD Feb 15, 2024

DejayJD Feb 15, 2024

DejayJD Feb 15, 2024

dylanjeffers Feb 15, 2024

audius-infra commented Feb 15, 2024

DejayJD Feb 15, 2024

dylanjeffers Feb 15, 2024

DejayJD Feb 15, 2024

dylanjeffers Feb 15, 2024

DejayJD Feb 15, 2024

audius-infra commented Feb 15, 2024

dylanjeffers left a comment

dylanjeffers Feb 15, 2024

dylanjeffers Feb 15, 2024

dylanjeffers Feb 15, 2024

dylanjeffers Feb 15, 2024

dylanjeffers Feb 15, 2024

Native Sign Up Various QA Fixes #7607

Native Sign Up Various QA Fixes #7607

Conversation

DejayJD commented Feb 15, 2024 • edited Loading

Description

How Has This Been Tested?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

audius-infra commented Feb 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

audius-infra commented Feb 15, 2024

dylanjeffers left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DejayJD commented Feb 15, 2024 •

edited

Loading